Skip to content
This repository has been archived by the owner on Apr 16, 2024. It is now read-only.

Use path for extension #773

Merged
merged 7 commits into from
Jun 14, 2018
Merged

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jun 10, 2018

Description:

Read extension of filename with path lib.

Improvements

  • Use Path-Lib for reading filename extension
  • Increase code coverage for media controller
  • Dont use .istanbul.yml as test file
  • Test case when no extension present

@coveralls
Copy link

coveralls commented Jun 10, 2018

Pull Request Test Coverage Report for Build 2538

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 67.141%

Totals Coverage Status
Change from base Build 2535: 0.2%
Covered Lines: 1238
Relevant Lines: 1773

💛 - Coveralls

@kesselb kesselb added this to Awaiting review/merge in Bugfix & Tweak-Release 0.8 Jun 12, 2018
@PatrickSkowronek PatrickSkowronek merged commit 816931b into develop Jun 14, 2018
@PatrickSkowronek PatrickSkowronek deleted the bugfix/use-path-for-extension branch June 14, 2018 14:08
@kesselb kesselb moved this from Awaiting review/merge to Done in Bugfix & Tweak-Release 0.8 Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants