⚠ WIP: Repair karma tests #894
Conversation
app/webFrontend/package.json
Outdated
| @@ -53,10 +53,9 @@ | |||
| "ngx-lightbox": "^1.0.2", | |||
| "node-sass": "^4.9.2", | |||
| "raven-js": "^3.26.2", | |||
| "socket.io": "^2.1.0", | |||
There was a problem hiding this comment.
I'm not sure about this one. Why do you remove it?
There was a problem hiding this comment.
It seems that this dependency was just used by one karma test. I'am not sure if we need it.
We use just rest and no sockets in my opinion.
There was a problem hiding this comment.
Afaik forum uses socket.io
There was a problem hiding this comment.
Well, then we need it probably.
|
I guess you know a bit about these tests? Could you have a look at https://github.com/geli-lms/geli/blob/develop/app/webFrontend/src/app/shared/services/snack-bar.service.spec.ts? These test is broken since we added i18n but I haven't figured out yet howto fix this. |
# Conflicts: # app/webFrontend/package-lock.json # app/webFrontend/package.json
|
@OliverNeff pushed some changes to your pr. Could you have a look at the app.component test? I'm not sure how to fix it properly. |
Description:
Karma tests are now runnable again, but there are a lot of tests failures in it.
Closes #655
Improvements
Known Issues:
NONE