Skip to content
This repository has been archived by the owner on Apr 16, 2024. It is now read-only.

Translation course media & access key #906

Merged
merged 3 commits into from
Oct 24, 2018
Merged

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Oct 23, 2018

Description:

Fix wrong call for translation. Buttons in course media. Placeholder for access key

Improvements

  • String is translated

Known Issues:

NONE

@kesselb kesselb added the enhancement This issue improves geli label Oct 23, 2018
@kesselb kesselb added this to Awaiting review/merge in Bugfix & Tweak-Release 0.8 Oct 23, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 163

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.4%) to 74.908%

Totals Coverage Status
Change from base Build 154: 1.4%
Covered Lines: 1749
Relevant Lines: 2236

💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 23, 2018

Pull Request Test Coverage Report for Build 174

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.3%) to 73.552%

Files with Coverage Reduction New Missed Lines %
api/src/controllers/DownloadController.ts 5 74.37%
api/src/models/units/CodeKataUnit.ts 20 58.78%
Totals Coverage Status
Change from base Build 172: -1.3%
Covered Lines: 1721
Relevant Lines: 2234

💛 - Coveralls

@kesselb kesselb merged commit 80cc110 into develop Oct 24, 2018
@kesselb kesselb deleted the bugfix/various-i18n-fixes branch October 24, 2018 21:01
@kesselb kesselb moved this from Awaiting review/merge to Done in Bugfix & Tweak-Release 0.8 Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement This issue improves geli
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants