Add a password replacing button to EditWindow (issue #84) #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scerzh
force-pushed
the
feat/edit-window-replace-button
branch
from
611ce64
to
369d17a
Compare
|
The line endings transformed to '\n' before locating the password line. Actually for the case when Environment.NewLine is '\r'. |
|
Looks good to me, although I think putting the button next to the 'generate' button will help communicate its purpose a bit more. That might require raising the minimum size of the window itself a bit, but that's not an issue. |
scerzh
force-pushed
the
feat/edit-window-replace-button
branch
from
369d17a
to
348d460
Compare
|
Yes, I agree putting the button next to the 'generate' button helps to see its purpose more clearly. I moved the button there. I'm having issues with building on the current master. |
scerzh
force-pushed
the
feat/edit-window-replace-button
branch
from
348d460
to
503980f
Compare
scerzh
force-pushed
the
feat/edit-window-replace-button
branch
2 times, most recently
from
14c83b8
to
9f3558a
Compare
scerzh
force-pushed
the
feat/edit-window-replace-button
branch
from
9f3558a
to
d847fc7
Compare
|
Yes, I think this way is perfect. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 3rd approach from #84
I tried
var index = content.IndexOf(Environment.NewLine, System.StringComparison.Ordinal);but that always returned -1. I switched to the following
var index = content.IndexOf('\n');