Implemented losses per event per asset #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -464,6 +464,16 @@ def job_from_file(cfg_file_path, username, log_level='info', exports=(), | |||
| hazard_output_id) | |||
|
|
|||
| params = vars(oqparam).copy() | |||
There was a problem hiding this comment.
Just a suggestion to remove some redundancy:
par_list = ['quantile_loss_curves', 'poes_disagg', 'poes_disagg', 'sites_disagg', 'sites_disagg', 'specific_assets', 'conditional_loss_poes']
for par in par_list:
if par not in params:
params[par] = []
There was a problem hiding this comment.
I prefer the keep the ugliness as it is, because the plan is to move the checks here from the engine into commonlib. Having a ugly series of ifs increases the likeness of cleaning this sooner ;-)
|
Apart from the Django model and the minor suggestion, LGTM |
micheles
added a commit
that referenced
this pull request
Oct 22, 2014
Implemented losses per event per asset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://bugs.launchpad.net/oq-engine/+bug/1383291 and the companion PR https://github.com/gem/oq-commonlib/pull/45. The tests are running here: https://ci.openquake.org/job/zdevel_oq-engine/766