Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed combine_pmaps for reduced logic trees #2503

Merged
merged 3 commits into from Feb 1, 2017
Merged

Fixed combine_pmaps for reduced logic trees #2503

merged 3 commits into from Feb 1, 2017

Conversation

micheles
Copy link
Contributor

Fixes a bug discovered by Elisabeth, happening when some source groups have probability of exceedence zero, i.e. empty probability maps.

@micheles micheles added the bug label Jan 31, 2017
@micheles micheles added this to the Engine 2.3.0 milestone Jan 31, 2017
@micheles
Copy link
Contributor Author

micheles commented Feb 1, 2017

I should add a test

daniviga
daniviga approved these changes Feb 1, 2017
View reviewed changes
Copy link
Contributor

@daniviga daniviga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micheles micheles merged commit a53589d into master Feb 1, 2017
@micheles micheles deleted the combine_pmaps branch February 1, 2017 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniviga daniviga daniviga approved these changes

@mmpagani mmpagani Awaiting requested review from mmpagani

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Engine 2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@micheles @daniviga