Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug when exporting hazard outputs by realization #2946

Merged
merged 9 commits into from Jul 4, 2017

Conversation

micheles
Copy link
Contributor

@micheles micheles commented Jul 4, 2017

As reported by Elisabeth on the mailing list, the command oq export hazard_output/rlz-XXX does not work as intended. Here I am fixing it.

@micheles micheles added the bug label Jul 4, 2017
@micheles micheles added this to the Engine 2.6.0 milestone Jul 4, 2017
@micheles micheles requested a review from ptormene July 4, 2017 07:30
@@ -0,0 +1,5 @@
# source_model_tree_path=('b1',),gsim_tree_path=('b12',),investigation_time=1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we have an inconsistency in the format of the comment line that contains parameters. Here parameters are separated by "," but somewhere else we have parameters separated by ", "
Please check about this.

Copy link
Member

@ptormene ptormene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests are green, LGTM

@micheles micheles merged commit 3216d6c into master Jul 4, 2017
@micheles micheles deleted the export-by-rlz branch July 4, 2017 09:31
@micheles
Copy link
Contributor Author

micheles commented Jul 4, 2017

They are green except for the heisenbug, so I am merging and fix the heisenbug immediately after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants