Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set upper limit for the Goda & Atkinson cross-correlation coeffient #9207

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

raoanirudh
Copy link
Member

The original formulation does not explicitly support PGA, so the engine implementation treats PGA as equivalent to SA(0.05). But this can lead to correlation coefficients > 1.0 for IMT pairs like {PGA, SA(0.1)}. Here, we simply limit the correlation coefficient to have an upper bound of 1.0.

@raoanirudh
Copy link
Member Author

As a side note, #7741 added a method to compute the cross-correlation matrix in the abstract base class, so perhaps the same method implemented for the GodaAtkinson2009 class can be safely replaced by the one in the base class @micheles ?

@micheles micheles added this to the Engine 3.19.0 milestone Nov 13, 2023
@micheles
Copy link
Contributor

micheles commented Nov 13, 2023

Maybe, you can try that and see if any tests breaks. For what concerns this PR, all looks good to me and I am going to merge it, after you update the changelog.

@micheles micheles merged commit 692e359 into master Nov 13, 2023
7 checks passed
@micheles micheles deleted the goda-atkinson-max-corr branch November 13, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants