Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log warning if all stations are beyond maximum_distance_stations #9275

Merged
merged 3 commits into from
Dec 28, 2023

Conversation

raoanirudh
Copy link
Member

And switch to the regular GMF computer / scenario calculator instead of using the conditioning procedure.

Sample job for testing: test.zip

…e_stations

And switch to the regular GMF computer / scenario calculator
instead of using the conditioning procedure
@micheles micheles added this to the Engine 3.19.0 milestone Dec 18, 2023
@micheles
Copy link
Contributor

micheles commented Dec 18, 2023

Running your test.zip file fails for me:

File "/home/michele/oq-engine/openquake/calculators/event_based.py", line 318, in filter_stations
    station_data = station_df[numpy.isin(station_df.index, station_sites.sids)]
                                                           ^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'sids'

@raoanirudh
Copy link
Member Author

Yes, that is the error the user gets with the current master, but the fix in the branch all-stns-filtered should handle it more gracefully by logging a warning and switching to the regular gmf computer.

@micheles micheles merged commit 779d470 into master Dec 28, 2023
6 checks passed
@micheles micheles deleted the all-stns-filtered branch December 28, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants