Improve performance of the non-parametric liquefaction models #9375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two updates help with the performance of ML models: 1. Read the .onnx ML model file only once per calculation. Previously it was being read each time the results were computed - resulting in 3,000 file reads for a scenario calculation involving 1,000 realizations × 3 GMMs, or hundreds of thousands of file reads for event based calculations. 2. Generate a single ONNX Runtime Inference Session, and make it possible to pass the session as an argument to the liquefaction compute method.
micheles
approved these changes
Jan 24, 2024
|
Looks very good to me, you are using the .prepare method as it was meant to be. Please remembet to update the changelog! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two updates to help with the performance of ML liquefaction models:
Resolves #9351. Order of magnitude improvement in the runtime for job_todorovic.ini in scenario.zip.