This repository has been archived by the owner on May 28, 2019. It is now read-only.
vuln: more consistent list page, no 'More details' button when no curve ... #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve selected and fix wrong default for curve_id
| @@ -54,8 +54,9 @@ def list_entries(request, **kwargs): | |||
| types_of_assessment[type_of_assessment].lower()) | |||
|
|
|||
| try: | |||
| curve_id = int(request.GET.get("curve", | |||
| TA.FRAGILITY)) | |||
There was a problem hiding this comment.
The second argument of get method is the default value to use when curve argument isn't set, the correct value is -1 not TA.FRAGILITY.
|
I am able to see 'Select a list item on the left' for just a brief moment, then the 'more details' button is shown before any function is selected |
|
LGTM |
nastasi-oq
added a commit
that referenced
this pull request
Jan 13, 2015
vuln: more consistent list page, no 'More details' button when no curve ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...selected and fix wrong default for curve_id.