Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update return Ressources #85 #93

Merged
merged 6 commits into from
May 26, 2023
Merged

update return Ressources #85 #93

merged 6 commits into from
May 26, 2023

Conversation

f-peverali
Copy link
Contributor

No description provided.

@f-peverali f-peverali requested a review from jcaumann May 22, 2023 14:28
@f-peverali f-peverali linked an issue May 22, 2023 that may be closed by this pull request
$book-Response (Kommentierung Stufe 3) #85
Closed
jcaumann
jcaumann requested changes May 22, 2023
View reviewed changes
Copy link
Contributor

@jcaumann jcaumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zu dem Beispiel: Sollte nicht serviceType 1..* sein? Dann muss das auch in dem Beispiel auftauchen.

@f-peverali
Copy link
Contributor Author

zu dem Beispiel: Sollte nicht serviceType 1..* sein? Dann muss das auch in dem Beispiel auftauchen.

@jcaumann, hier habe ich die Beispiele angepasst: f361f92

Beim meta-tag in der Antwort bin ich mir unsicher. Was denkst Du?

Zusätzlich habe ich eine User Story vorgeschlagen. Auch hier gerne Verbesserungsvorschläge einbringen, die leicht mit den Beispiel-Instanzen harmonisiert werden können.

@f-peverali f-peverali requested a review from jcaumann May 23, 2023 08:18
jcaumann
jcaumann reviewed May 25, 2023
View reviewed changes
ImplementationGuide/markdown/Datenobjekte/Operations.md
],
"status": "booked",
"start": "2022-12-10T09:00:00Z",
"end": "2022-12-10T11:00:00Z",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ist ein 2-Stunden-Slot realistisch? ich würde als Ende in dem Beispiel besser 2022-12-10T09:30:00Z verwenden. (es sei denn, dass derselbe Slot auch als Beispiel für die Slot-Ressource verwendet wird und da wirklich auf 2 Stunden gesetzt ist).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in neuer Issue als TC lösen

jcaumann
jcaumann requested changes May 25, 2023
View reviewed changes
Copy link
Contributor

@jcaumann jcaumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

siehe Kommentare

This was referenced May 26, 2023
Closed
Closed
Closed
Closed
Closed
Closed
@f-peverali f-peverali requested a review from jcaumann May 26, 2023 08:10
@f-peverali f-peverali merged commit 4c063fd into 3.0.0-rc2 May 26, 2023
@f-peverali f-peverali deleted the update/book_return-to-appointment branch May 26, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcaumann jcaumann Awaiting requested review from jcaumann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$book-Response (Kommentierung Stufe 3)
2 participants
@f-peverali @jcaumann