Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Action not triggering another workflow / ignoring GITHUB_TOKEN override #73

Closed
Bastianowicz opened this issue Mar 27, 2024 · 3 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@Bastianowicz
Copy link

Bastianowicz commented Mar 27, 2024

What happened?

In my project I have to separate workflows.

One is for "release" which is the uplift action triggering uplift release. This action I configured to use a personal access token instead of the GITHUB_TOKEN (like said in the docs).
❌ This does not seem to work though. The tags created are still authored by uplift bot.

The other is to publish the new version to npm. This does work when I manually push a tag. But it does not automatically after the release pipeline ran since the tags are still being created by the uplift bot.

Further the PAT in the settings says "never used". I regenerated it and added it freshly as an action secret. It does not seem to be applied to the action since it says "never used" nevertheless.

Steps to reproduce it

1. Create a workflow "X" that runs on any created tag.
2. Override your Github_token like in the [docs](https://upliftci.dev/ci/github/#triggering-another-workflow)
3. Commit a fix or feat commit and thus run the uplift action

## expected behaviour
* X runs after the uplift action ran
* the tag is authored by you (your PAT)

## experienced
* the tag is still authored by Uplift Bot
* of course the workflow X does not run

Your uplift action configuration

  release:
    name: Release
    if: github.ref == 'refs/heads/main' && !startsWith( github.event.commits[0].message, 'build(deps-dev)') && !startsWith( github.event.commits[0].message, 'ci(uplift)')
    runs-on: ubuntu-latest
    needs: test
    steps:
      - uses: actions/checkout@v4
        with:
          fetch-depth: 0
      - name: Release
        if: github.ref == 'refs/heads/main'
        uses: gembaadvantage/uplift-action@v2.0.1
        with:
          args: release
        env:
          GITHUB_TOKEN: ${{ secrets.GH_TOKEN_UPLIFT }}

Which version?

v2.0.1

Optional debug output

No response

@Bastianowicz Bastianowicz added the bug Something isn't working label Mar 27, 2024
@Bastianowicz
Copy link
Author

@ga-paul-t if you'd point me a rough direction why this happens i'd be happy to raise a pull request

Copy link

stale bot commented May 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 2, 2024
@stale stale bot closed this as completed May 10, 2024
@Bastianowicz
Copy link
Author

this is not completed by any terms... maybe someone has an idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants