Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect scintillation sigma calc #123

Open
agoose77 opened this issue Jan 9, 2018 · 0 comments
Open

Incorrect scintillation sigma calc #123

agoose77 opened this issue Jan 9, 2018 · 0 comments

Comments

@agoose77
Copy link
Contributor

agoose77 commented Jan 9, 2018 •
edited
Loading

source/hitprocess/clas12/ec_hitprocess.cc

Line 234 in 9b2cf10

double sigma = ecc.pmtFactor/sqrt(EC_npe);

I could be wrong, but given that
SNR=NPE/sigma, then sigma = NPE/SNR. With the RCA handbook giving SNR=sqrt(NPE)/pmtFactor, shouldn't the code linked above be calculating sigma as sigma=sqrt(NPE)*pmtFactor?

In the source it mentions

Note: GSIM sigma was incorrect (used 1/sigma for sigma).

But I am not sure quite what this refers to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@agoose77