feat: add ErrorOrNil #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yag13s
commented
Dec 12, 2021
| @@ -118,6 +148,12 @@ func (e *errs) As(target interface{}) bool { | |||
| } | |||
|
|
|||
| func (e *errs) PrettyPrint() { | |||
| if e == nil { | |||
There was a problem hiding this comment.
This logic is not work. ( It's not a bug, but a fundamental problem that needs to be solved. )
yag13s
commented
Dec 12, 2021
| @@ -10,6 +10,10 @@ import ( | |||
| "github.com/stretchr/testify/assert" | |||
| ) | |||
|
|
|||
| type somethingError struct{} | |||
There was a problem hiding this comment.
I was just curious about the order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
add ErrorOrNil on issue No.39.
We have taken this action for now, but we believe that the next version (1.1.0 or later) will require a fundamental solution.
# (issue No.39)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: