Use Fixnum code for errors. Sinatra relies on this to correctly repor…

…t Error statuses.
geminabox · Feb 15, 2016 · d16bb50 · d16bb50
1 parent 8973373
commit d16bb50
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/lib/geminabox/gem_store_error.rb b/lib/geminabox/gem_store_error.rb
@@ -6,7 +6,7 @@ class GemStoreError < StandardError
     include Nesty::NestedError
 
     def initialize(code, reason)
-      @code = code.to_s
+      @code = code
       @reason = reason
     end
   end

diff --git a/test/units/geminabox/gem_store_error_test.rb b/test/units/geminabox/gem_store_error_test.rb
@@ -7,7 +7,7 @@ def test_error
       begin
         raise GemStoreError.new(500, reason)
       rescue GemStoreError => error
-        assert_equal(code.to_s, error.code)
+        assert_equal(code, error.code)
         assert_equal(reason, error.reason)
       end
     end

diff --git a/test/units/geminabox/gem_store_test.rb b/test/units/geminabox/gem_store_test.rb
@@ -9,15 +9,15 @@ def setup
     def test_prepare_data_folders_with_data_as_file
       Geminabox.data = File.join(__FILE__)
       gem_store = GemStore.new(gem_file(:example))
-      assert_gem_store_error('500', 'is a directory') do
+      assert_gem_store_error(500, 'is a directory') do
         gem_store.prepare_data_folders
       end
     end
 
     def test_prepare_data_folders_with_data_as_unwriteable_folder
       Geminabox.data = '/'
       gem_store = GemStore.new(gem_file(:example))
-      assert_gem_store_error('500', 'is writable') do
+      assert_gem_store_error(500, 'is writable') do
         gem_store.prepare_data_folders
       end
     end
@@ -35,7 +35,7 @@ def test_prepare_data_folders
     def test_ensure_gem_valid
       invalid_gem = Geminabox::IncomingGem.new(StringIO.new('NOT A GEM'))
       gem_file = GemStore.new invalid_gem
-      assert_gem_store_error('400', 'Cannot process gem') do
+      assert_gem_store_error(400, 'Cannot process gem') do
         gem_file.ensure_gem_valid
       end
     end