Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak #298

Merged
merged 1 commit into from
Jan 25, 2018
Merged

Fix memory leak #298

merged 1 commit into from
Jan 25, 2018

Conversation

sonots
Copy link
Member

@sonots sonots commented Jan 18, 2018

Fix #299

Rack::Session::Pool causes memory leak. Also, it is not available for multiprocess server such as unicorn. Make it configurable by users.

README.md Outdated

# Use Rack::Protection to prevent XSS and CSRF vulnerability if your geminabox server is open public.
# Rack::Protection requires a session middleware, choose your favorite one such as Rack::Session::Memcache.
# This example uses Rack::Session::Pool for simplicity, but please noe that:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noe

I assume a typo. "Know"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, note. Thanks.

Make it configurable by users.
@sonots
Copy link
Member Author

sonots commented Jan 18, 2018

I will merge this after checking on my production.

@sonots
Copy link
Member Author

sonots commented Jan 25, 2018

Memory leak stopped at my environment. I am going to merge.

@sonots sonots merged commit 0dabab6 into geminabox:master Jan 25, 2018
@sonots sonots deleted the fix_memory_leak branch January 25, 2018 03:46
@sonots
Copy link
Member Author

sonots commented Jan 25, 2018

0.13.14 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants