Update Dockerfile #305
Merged
Update Dockerfile #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem ==== The Dockerfile does not work currently. Because the ruby-onbuild image does not work with a gemspec. See docker-library/ruby#22 ``` $ docker build -t geminabox . Sending build context to Docker daemon 880.1kB Step 1/4 : FROM ruby:2.3.0-onbuild ---> Using cache ---> Using cache ---> Running in 926fd054cc66 [!] There was an error parsing `Gemfile`: There are no gemspecs at /usr/src/app. Bundler cannot continue. # from /usr/src/app/Gemfile:3 # ------------------------------------------- # > gemspec # group :development do # ------------------------------------------- ``` Solution ==== Use ruby (without "onbuild") image instead. The `Dockerfile` inherits `ruby:2.4.3`, and the file content bases `ruby-onbuild`. https://github.com/docker-library/ruby/blob/a6918175fd506b46bf2d8f899f4faa40e72296fb/2.3/jessie/onbuild/Dockerfile In the `Dockerfile`, it copies app files into a docker container before `bundle install` to avoid the problem. Note === This change updates Ruby version from 2.3.0 to 2.4.3. I guess 2.4.3 is latest supported version (See https://github.com/geminabox/geminabox/blob/50e0253478b16fa8cc4ea5f88359447ede022869/.travis.yml ).
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Dockerfile does not work currently. Because the ruby-onbuild image does not work with a gemspec. See docker-library/ruby#22
Solution
Use ruby (without "onbuild") image instead.
The
Dockerfileinheritsruby:2.4.3, and the file content basesruby-onbuild.https://github.com/docker-library/ruby/blob/a6918175fd506b46bf2d8f899f4faa40e72296fb/2.3/jessie/onbuild/Dockerfile
In the
Dockerfile, it copies app files into a docker container beforebundle installto avoid the problem.Note
This change updates Ruby version from 2.3.0 to 2.4.3. I guess 2.4.3 is latest supported version (See https://github.com/geminabox/geminabox/blob/50e0253478b16fa8cc4ea5f88359447ede022869/.travis.yml ).