Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use environmental TMPDIR for lockfile, and add 'rss' as dependency. #346

Merged
merged 5 commits into from
May 29, 2021
Merged

Use environmental TMPDIR for lockfile, and add 'rss' as dependency. #346

merged 5 commits into from
May 29, 2021

Conversation

jubishop
Copy link
Contributor

@jubishop jubishop commented Mar 26, 2021

Basic premise here is that some systems (including the one I'm using) don't allow writes to /tmp. And any standard system should be using the TMPDIR env var to identify where you can actually write to tmp, however this still falls back to /tmp in the cases where the var simply doesn't exist, which should make it a non-breaking change for current users.

Also for whatever reason on all my systems I can't bundle it unless I add the gem rss...I'm using Ruby 3.0.

@jubishop jubishop changed the title Use environmental TMPDIR for lockfile. Many systems don't let you us… Use environmental TMPDIR for lockfile, and add 'rss' as dependency. Mar 26, 2021
@NobodysNightmare
Copy link
Contributor

Also for whatever reason on all my systems I can't bundle it unless I add the gem rss...I'm using Ruby 3.0.

Using Ruby 3 is the culprit for that. As you can see here: https://stdgems.org/rss/

Before 3.0 this was a default gem (i.e. nothing needed to require it), since then it is only bundled (i.e. you have to install it separately)

@sonots
Copy link
Member

sonots commented May 29, 2021

lgtm

@sonots sonots merged commit 01d7456 into geminabox:master May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants