Replace jQuery-based scripts with vanilla JS #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
|
Test on Travis-ci |
|
@sonots What do you think? |
|
Comments? |
|
Thoughts? @sonots |
|
@tomlea Are you still in charge of this gem? See https://guides.rubygems.org/contributing/ updated in rubygems/guides#222 (in 2018) |
|
@tnir I think it makes sense. I'm usually not the one merging requests here, but since this is not even ruby related and no one's replying I'll give it a go. Thanks! |
|
Thanks a lot for resolving this security issue on this project, @rikas! |
Closed
tnir
added a commit
to tnir/geminabox
that referenced
this pull request
Jun 25, 2022
Fix lints in PR 361: geminabox#361 Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
tnir
added a commit
that referenced
this pull request
Jun 25, 2022
Fix lints in PR 361: #361 Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jQuery 1.5 is so legacy and insecure.
This PR will drop IE6-8 support from the supported browsers (not tested if this PR actually drops IE6-8 support).
Closes #362
Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com