Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update certificates #363

Merged
merged 1 commit into from
Jun 1, 2022
Merged

update certificates #363

merged 1 commit into from
Jun 1, 2022

Conversation

ahorek
Copy link
Contributor

@ahorek ahorek commented Jun 27, 2021

  • the certificate from test fixtures is too short and considered insecure on new rubies, so just generate a more secure one
    fixes SSLtest fails only on Ubuntu 20.04 (focal) #359
  • use localhost instead of 127.0.0.1, because tests shouldn't depend on IPv4 protocol

@tnir
Copy link
Member

tnir commented Jun 28, 2021

Thanks. I tried to use a new certificate with valid notBefore/notAfter signed with the original 1024-bit key, so could not fix it on my local 😁

@tnir
Copy link
Member

tnir commented Jul 18, 2021

@tomlea Thoughts?

@tnir
Copy link
Member

tnir commented Jun 1, 2022

@rikas Could you merge this PR in advance to merged #366? Or choose someone else in charge of this?

@rikas
Copy link
Member

rikas commented Jun 1, 2022

@tnir I'm not very good with certificates and encryption stuff so I don't know exactly what implications this might have. I would prefer to not do it myself without the review of @sonots or @reggieb.

Tom Lea, the original maintainer is not around anymore. I hope one of the above will be... otherwise I'll do it myself.

Copy link
Member

@reggieb reggieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rikas
Copy link
Member

rikas commented Jun 1, 2022

Ok, I'll merge then! This is from almost a year ago. PRs are taking a very long time to be merged due to inactivity 😞

@rikas rikas merged commit 0cd1efa into geminabox:master Jun 1, 2022
@tnir
Copy link
Member

tnir commented Jun 1, 2022

Thanks @rikas and @reggieb!

@rikas
Copy link
Member

rikas commented Jun 1, 2022

Thanks for pushing this forward @tnir 👍

@tnir tnir added the test label Jun 20, 2022
@tnir tnir added this to the v1.4.3 milestone Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

SSLtest fails only on Ubuntu 20.04 (focal)
4 participants