eliminate a faraday 1.x deprecation warning #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnir
requested changes
Jun 8, 2022
|
@tnir what change to the code do you suggest? I can't find any. |
|
I thought I would do that after I become a maintainer and release the gem. |
skaes
force-pushed
the
eliminate-faraday-basic-auth-deprecation-warning
branch
from
52c0adc
to
5c2ac96
Compare
|
Moving this forward upcoming milestone. |
|
I'll try to fix the Ruby 2.2.10 problem. |
skaes
force-pushed
the
eliminate-faraday-basic-auth-deprecation-warning
branch
4 times, most recently
from
982a0c0
to
05dcbc1
Compare
skaes
force-pushed
the
eliminate-faraday-basic-auth-deprecation-warning
branch
from
05dcbc1
to
3ec302e
Compare
|
@tnir sorry for the confusion. Should be complete by now. |
This was referenced Jun 28, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://lostisland.github.io/faraday/middleware/authentication.