Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile #487

Closed
wants to merge 4 commits into from
Closed

Update Dockerfile #487

wants to merge 4 commits into from

Conversation

mohitsaxenaknoldus
Copy link

@mohitsaxenaknoldus
Update Dockerfile
0f37aa4 
Signed-off-by: Mohit Saxena <76725454+mohitsaxenaknoldus@users.noreply.github.com>
@mohitsaxenaknoldus mohitsaxenaknoldus mentioned this pull request Sep 4, 2022
Closed
@tnir tnir self-requested a review September 5, 2022 09:44
tnir
tnir requested changes Sep 6, 2022
View reviewed changes
Copy link
Member

@tnir tnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to remove mkdir -p, you should remove only a single line.

@tnir tnir self-assigned this Sep 6, 2022
@mohitsaxenaknoldus
Update Dockerfile
663aab2 
Signed-off-by: Mohit Saxena <76725454+mohitsaxenaknoldus@users.noreply.github.com>
@mohitsaxenaknoldus
Copy link
Author

mohitsaxenaknoldus commented Sep 8, 2022 •
edited
Loading

If you want to remove mkdir -p, you should remove only a single line.

Fixed.

@mohitsaxenaknoldus
Copy link
Author

@tnir Is this good to merge now?

@github-actions
Copy link

You should update this pull request by commenting on it. Otherwise the PR will be closed in 14 days.

@mohitsaxenaknoldus
Copy link
Author

@tnir Does this need further changes?

@github-actions
Copy link

You should update this pull request by commenting on it. Otherwise the PR will be closed in 14 days.

@github-actions github-actions bot closed this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnir tnir Awaiting requested review from tnir

Assignees

@tnir tnir

Labels
no-pr-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mohitsaxenaknoldus @tnir