Make the width contain units and add start/end functions #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Quiroz <carlos.quiroz@noirlab.edu>
swalker2m
approved these changes
Sep 1, 2021
|
Yeah. I was a bit surprised too |
toddburnside
reviewed
Sep 1, 2021
| ) extends Product with Serializable { | ||
| require(center.toPicometers.value >= width.value / 2) | ||
|
|
||
| def end: Wavelength = Wavelength(center.toPicometers + (width.value.value / 2).withRefinedUnit[Positive, Nanometer]) |
There was a problem hiding this comment.
Not a big deal here, but I think you can avoid stripping the units off width for the division and then adding them back on by center.toPicometers + width / 2.withRefinedUnit[Positive, Unitless].
There was a problem hiding this comment.
yes you can see
erikerlandson/coulomb#211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Band's width has no units. It should be nanometers