Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move a few things from the ODB #906

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Move a few things from the ODB #906

merged 1 commit into from
Jun 12, 2024

Conversation

toddburnside
Copy link
Contributor

No description provided.

case RegularSemester extends CallForProposalsType("regular_semester", "Regular Semester")
case SystemVerification extends CallForProposalsType("system_verification", "System Verification")

def subTypes: NonEmptyList[ScienceSubtype] =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was included in the Explore version of this enum, so I ported it here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is generally useful

@mergify mergify bot added the core label Jun 12, 2024
Copy link
Collaborator

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toddburnside toddburnside merged commit 8263625 into master Jun 12, 2024
9 checks passed
@toddburnside toddburnside deleted the from_odb branch June 12, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants