reuse-loader: use report archive with files (not report dir itself) #109

miripiruni · 2018-03-30T14:25:42Z

See: FEI-9200

Warning: major changes.

j0tunn · 2018-03-30T14:50:18Z

lib/reuse-loader.js

-
-            return path.resolve(tempDir, reportDirName);
-        });
+        .then(() => path.resolve(tempDir));


зачем здесь path.resolve? В tempDir лежит абсолютный путь

🤦‍♂️

j0tunn · 2018-03-30T14:54:19Z

test/reuse-loader.js

@@ -119,15 +119,11 @@ describe('lib/reuse-loader', () => {
    it('should choose folder from temp dir for reuse', () => {


теперь title не соответствует тому, что делается в тесте

See: FEI-9200

miripiruni requested review from Flackus and j0tunn March 30, 2018 14:25

j0tunn approved these changes Mar 30, 2018

View reviewed changes

miripiruni force-pushed the FEI-9200 branch 2 times, most recently from 493ec8a to 800c93f Compare March 30, 2018 15:50

reuse-loader: use report archive with files (not report dir itself)

9cc6db6

See: FEI-9200

miripiruni force-pushed the FEI-9200 branch from 800c93f to 9cc6db6 Compare March 30, 2018 15:55

Flackus approved these changes Mar 30, 2018

View reviewed changes

j0tunn approved these changes Mar 30, 2018

View reviewed changes

miripiruni merged commit b61c346 into master Mar 30, 2018

miripiruni deleted the FEI-9200 branch March 30, 2018 17:06

Provide feedback

		@@ -119,15 +119,11 @@ describe('lib/reuse-loader', () => {
		it('should choose folder from temp dir for reuse', () => {