fix up

gemini-testing · Aug 31, 2016 · 7797cd9 · 7797cd9
1 parent c5e2508
commit 7797cd9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/lib/runner/suite-runner/regular-suite-runner.js b/lib/runner/suite-runner/regular-suite-runner.js
@@ -27,7 +27,7 @@ module.exports = class RegularSuiteRunner extends SuiteRunner {
             .then((browser) => this._initSession(browser))
             .then(() => this._processStates(stateProcessor))
             .catch((e) => {
-                this._handleError(e);
+                this._validateSession(e);
 
                 return this._passErrorToStates(e);
             })
@@ -92,7 +92,7 @@ module.exports = class RegularSuiteRunner extends SuiteRunner {
         return promiseUtils.seqMap(this._suite.states, (state) => this._runStateInSession(state, stateProcessor));
     }
 
-    _handleError(error) {
+    _validateSession(error) {
         if (!(error instanceof NoRefImageError)) {
             this._browserAgent.invalidateSession();
         }
@@ -112,7 +112,7 @@ module.exports = class RegularSuiteRunner extends SuiteRunner {
         ]);
 
         runner.on(RunnerEvents.ERROR, (e) => {
-            this._handleError(e);
+            this._validateSession(e);
 
             this.emit(RunnerEvents.ERROR, e);
         });

diff --git a/test/unit/runner/browser-runner/browser-agent.js b/test/unit/runner/browser-runner/browser-agent.js
@@ -41,7 +41,7 @@ describe('runner/browser-runner/browser-agent', function() {
         assert.calledWith(browserPool.freeBrowser, sinon.match.any, {force: true});
     });
 
-    it('should free browser conditionally if session was not invalidated', () => {
+    it('should free browser if session was not invalidated', () => {
         const browserAgent = BrowserAgent.create('browser', browserPool);
 
         browserAgent.freeBrowser();

diff --git a/test/unit/runner/suite-runner/regular-suite-runner.js b/test/unit/runner/suite-runner/regular-suite-runner.js
@@ -447,7 +447,7 @@ describe('runner/suite-runner/regular-suite-runner', () => {
                     });
             });
 
-            it('should not invalidate session after `NoRefImageError`', () => {
+            it('should not invalidate session if reference image does not exist', () => {
                 CaptureSession.prototype.runActions.returns(q.reject(new NoRefImageError()));
 
                 return run_()