feat(calibrator): move to gemini-core

gemini-testing · Jan 12, 2018 · cb25445 · cb25445
1 parent 5006927
commit cb25445
Show file tree

Hide file tree

Showing 12 changed files with 181 additions and 423 deletions.
diff --git a/lib/browser-pool.js b/lib/browser-pool.js
@@ -1,7 +1,6 @@
 'use strict';
 
-const BrowserPool = require('gemini-core').BrowserPool;
-const Calibrator = require('./calibrator');
+const {BrowserPool, Calibrator} = require('gemini-core');
 const Browser = require('./browser');
 const Events = require('./constants/events');
 

diff --git a/lib/browser/camera.js b/lib/browser/camera.js
@@ -63,12 +63,10 @@ module.exports = class Camera {
             return image;
         }
 
-        return image.crop({
-            left: this._calibration.left,
-            top: this._calibration.top,
-            width: image.getSize().width - this._calibration.left,
-            height: image.getSize().height - this._calibration.top
-        });
+        const {left, top} = this._calibration;
+        const {width, height} = image.getSize();
+
+        return image.crop({left, top, width: width - left, height: height - top});
     }
 
     _cropToViewport(image, page) {

diff --git a/lib/browser/client-scripts/gemini.calibrate.js b/lib/browser/client-scripts/gemini.calibrate.js
diff --git a/lib/calibrator.js b/lib/calibrator.js