This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
Cast result of all wd method to Bluebird promises #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
а зачем это? |
|
@j0tunn |
|
need some tests for |
|
@sipayRT готово |
sipayRT
reviewed
Oct 10, 2016
| }); | ||
|
|
||
| wrapped = wd.promiseRemote(); | ||
| sandbox = sinon.sandbox.create(); |
There was a problem hiding this comment.
вынеси из beforeEach, плз - ты ведь ресторишь его в afterEach и не изменяешь по ходу тестов
sipayRT
reviewed
Oct 10, 2016
| }); | ||
|
|
||
| afterEach(() => { | ||
| sandbox.restore(); |
|
в остальном ок |
DudaGod
reviewed
Oct 10, 2016
| sandbox.restore(); | ||
| }); | ||
|
|
||
| it('should cast original promise to Blubird', () => { |
|
|
||
| if (EventEmitter.prototype[methodName]) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
А почему так не написать:
if (Object.prototype[methodName] || EventEmitter.prototype[methodName]) {
return false;
}There was a problem hiding this comment.
раздельно лучше читаются условия
| exports.promiseRemote = (gridUrl) => { | ||
| const remote = wd.promiseRemote(gridUrl); | ||
|
|
||
| const bluebirdRemote = {}; |
There was a problem hiding this comment.
а зачем тут пробел между переменными?
Introduce small wd-bluebird module, which just wraps existing wd methods and cast the result to Blubird promise.
SevInf
force-pushed
the
fix/wd-bluebird
branch
from
ded8922
to
c98b9fa
Compare
sipayRT
approved these changes
Oct 10, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce small wd-bluebird module, which just wraps existing
wd methods and cast the result to Blubird promise.
/cc @sipayRT @j0tunn @DudaGod