Skip to content
This repository has been archived by the owner on Sep 21, 2022. It is now read-only.

npm failed to install due to old polyfill-service dep #673

Closed

Conversation

SpaceK33z
Copy link

By upgrading the polyfill-service, npm or yarn will no longer fail to install because of this message:

npm ERR! notsup Unsupported engine for hawk@0.10.2: wanted: {"node":"0.8.x"} (current: {"node":"6.8.1","npm":"3.10.8"})
npm ERR! notsup Not compatible with your version of node/npm: hawk@0.10.2
npm ERR! notsup Not compatible with your version of node/npm: hawk@0.10.2
npm ERR! notsup Required: {"node":"0.8.x"}
npm ERR! notsup Actual:   {"npm":"3.10.8","node":"6.8.1"}

In #635 it is mentioned that previously it wasn't possible to update since polyfill-service produced some console.log's that couldn't be hidden, but this was fixed in 3.13.0.

Fixes #635

@levonet levonet added the review label Nov 15, 2016
SevInf pushed a commit that referenced this pull request Nov 16, 2016
Fixes a lot of warnings regarding outdated dependecies and allows
to install gemini with yarn.

Close #673, close #635
@SevInf SevInf self-assigned this Nov 16, 2016
SevInf pushed a commit that referenced this pull request Nov 16, 2016
Fixes a lot of warnings regarding outdated dependecies and allows
to install gemini with yarn.

Close #673, close #635
@SevInf
Copy link
Contributor

SevInf commented Nov 16, 2016

Thanks for the contribution.
In the end, we've decided that pulling in 200MB website for picking 2 polyfills is not that good of idea, so we've removed the dependency altogether. For continuation see #674

@SevInf SevInf closed this Nov 16, 2016
@SevInf SevInf removed the review label Nov 16, 2016
@SpaceK33z
Copy link
Author

@SevInf, oh that's even better, 200MB is really huge indeed.

@SpaceK33z SpaceK33z deleted the upgrade-polyfill-service branch November 16, 2016 14:19
SevInf pushed a commit that referenced this pull request Nov 17, 2016
Fixes a lot of warnings regarding outdated dependecies and allows
to install gemini with yarn.

Close #673, close #635
SevInf pushed a commit that referenced this pull request Nov 18, 2016
Fixes a lot of warnings regarding outdated dependecies and allows
to install gemini with yarn.

Close #673, close #635
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn install fails for gemini
3 participants