This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
feat: Pass suiteCollection on BEGIN event to allow to modify it #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvmamich
reviewed
Feb 9, 2017
doc/events.md
Outdated
| @@ -16,3 +16,9 @@ | |||
| * `START_BROWSER` - emitted on browser session start. Emitted with [browser instance](../lib/browser/new-browser.js). If handler returns a promise tests will be executed in this session only after the promise is resolved. | |||
|
|
|||
| * `STOP_BROWSER` - emitted right before browser session end. Emitted with [browser instance](../lib/browser/new-browser.js). If handler returns a promise quit will be performed only after the promise is resolved. | |||
|
|
|||
| * `BEGIN` - runner event. Emitted on runner start with 1 argment `data`: | |||
kvmamich
reviewed
Feb 9, 2017
test/unit/runner/index.js
Outdated
| @@ -133,6 +133,17 @@ describe('runner', () => { | |||
| return run(runner).then(() => assert.calledOnce(onBegin)); | |||
| }); | |||
|
|
|||
| it('should suite collection of states when emitting "BEGIN" event', () => { | |||
There was a problem hiding this comment.
when emitting "BEGIN" event --> on "BEGIN" event
sipayRT
reviewed
Feb 9, 2017
doc/events.md
Outdated
| @@ -16,3 +16,9 @@ | |||
| * `START_BROWSER` - emitted on browser session start. Emitted with [browser instance](../lib/browser/new-browser.js). If handler returns a promise tests will be executed in this session only after the promise is resolved. | |||
|
|
|||
| * `STOP_BROWSER` - emitted right before browser session end. Emitted with [browser instance](../lib/browser/new-browser.js). If handler returns a promise quit will be performed only after the promise is resolved. | |||
|
|
|||
| * `BEGIN` - runner event. Emitted on runner start with 1 argment `data`: | |||
| * `data.suiteCollection` - suite collection which will be run | |||
There was a problem hiding this comment.
нужно указать или все свойства через data., или все без нее
|
🆙 |
|
🆗 |
j0tunn
force-pushed
the
suite.collection.on.begin
branch
from
715024e
to
7d04923
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.