fix: support the changed field names #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
DudaGod
commented
Nov 20, 2018
DudaGod
commented
- "refImagePath" -> "refImg.path"
- "currentImagePath" -> "currImg.path"
* "refImagePath" -> "refImg.path" * "currentImagePath" -> "currImg.path"
rostik404
approved these changes
Nov 23, 2018
sipayRT
approved these changes
Nov 26, 2018
| @@ -4,10 +4,10 @@ const compareImages = require('@gemini-testing/resemblejs/compareImages'); | |||
| const util = require('util'); | |||
| const debug = require('debug')('hermione-reassert-view'); | |||
|
|
|||
| exports.compareImages = async function({refImagePath, currentImagePath, maxDiffSize}) { | |||
| exports.compareImages = async function({refImgPath, currImgPath, maxDiffSize}) { | |||
There was a problem hiding this comment.
для чего ты поменял названия ключей самого плагина? оно бы и без этих изменений работало
There was a problem hiding this comment.
поменял для консистентности
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.