fix: system.debug config field #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuznetsovRoman
commented
Apr 5, 2023
src/base-hermione.js
Outdated
Comment on lines
60
to
64
| _setLogLevel() { | ||
| if (!process.env.WDIO_LOG_LEVEL) { | ||
| process.env.WDIO_LOG_LEVEL = _.get(this.config, "system.debug", false) ? "trace" : "error"; | ||
| } | ||
| } |
There was a problem hiding this comment.
После загрузки конфига, устанавливаем переменную окружения WDIO_LOG_LEVEL основываясь на поле в конфиге, при этом если переменная среды уже установлена, не затираем ее
| [ | ||
| { debug: true, WDIO_LOG_LEVEL: "trace" }, | ||
| { debug: false, WDIO_LOG_LEVEL: "error" }, | ||
| { WDIO_LOG_LEVEL: "error" }, |
There was a problem hiding this comment.
проверка logLevel по умолчанию
xrsd
approved these changes
Apr 5, 2023
KuznetsovRoman
force-pushed
the
HERMIONE-727.system_debug
branch
4 times, most recently
from
999e562
to
4a4f68e
Compare
KuznetsovRoman
force-pushed
the
HERMIONE-727.system_debug
branch
2 times, most recently
from
30e3046
to
cb37c08
Compare
KuznetsovRoman
force-pushed
the
HERMIONE-727.system_debug
branch
2 times, most recently
from
12604bb
to
e5cd031
Compare
KuznetsovRoman
force-pushed
the
HERMIONE-727.system_debug
branch
from
e5cd031
to
4f3e01c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что сделано
Починил
system.debugв конфигеУстановил дефолтное значение
LOG_LEVELна"error"