Merge pull request #748 from gemini-testing/feat/rm.runnable.type.pro…

…perty

feat: remove runnable type property

src/test-reader/test-object/hook.js

@@ -14,10 +14,6 @@ class Hook extends TestObject {
         }).assign(this);
     }
 
-    get type() {
-        return "hook";
-    }
-
     get file() {
         return this.parent.file;
     }

src/test-reader/test-object/test.js

@@ -15,10 +15,6 @@ class Test extends ConfigurableTestObject {
             fn: this.fn,
         }).assign(this);
     }
-
-    get type() {
-        return "test";
-    }
 }
 
 module.exports = {

src/worker/runner/test-runner/execution-thread.js

@@ -39,7 +39,7 @@ module.exports = class ExecutionThread {
         let fnPromise = Promise.method(runnable.fn).call(this._ctx, this._ctx);
 
         if (runnable.timeout) {
-            const msg = `${runnable.type} '${runnable.fullTitle()}' timed out after ${runnable.timeout} ms`;
+            const msg = `'${runnable.fullTitle()}' timed out after ${runnable.timeout} ms`;
             fnPromise = fnPromise.timeout(runnable.timeout, msg);
         }
 

test/src/test-reader/test-object/hook.js

@@ -82,14 +82,6 @@ describe("test-reader/test-object/hook", () => {
         });
     });
 
-    describe("type", () => {
-        it('should be "hook"', () => {
-            const hook = new Hook({});
-
-            assert.equal(hook.type, "hook");
-        });
-    });
-
     describe("file", () => {
         it("should return parent file", () => {
             const hook = new Hook({});

test/src/test-reader/test-object/test.js

@@ -78,12 +78,4 @@ describe("test-reader/test-object/test", () => {
             assert.calledOn(Test.prototype.assign, clonedTest);
         });
     });
-
-    describe("type", () => {
-        it('should be "test"', () => {
-            const test = new Test({});
-
-            assert.equal(test.type, "test");
-        });
-    });
 });

test/src/worker/runner/test-runner/execution-thread.js

@@ -219,7 +219,7 @@ describe("worker/runner/test-runner/execution-thread", () => {
 
             const executionThread = mkExecutionThread_();
 
-            await assert.isRejected(executionThread.run(runnable), /test 'bla bla' timed out/);
+            await assert.isRejected(executionThread.run(runnable), /'bla bla' timed out/);
         });
 
         it("should not set timeout if timeouts are disabled", async () => {