Merge pull request #754 from gemini-testing/HERMIONE-954.fix_hermione…

…_halt fix: show error with stack trace on call hermione.halt method
gemini-testing · Apr 3, 2023 · 67e630e · 67e630e
2 parents b5941d6 + 61cfc26
commit 67e630e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/hermione.js b/src/hermione.js
@@ -97,7 +97,7 @@ module.exports = class Hermione extends BaseHermione {
     }
 
     halt(err, timeout = 60000) {
-        logger.error(`Terminating on critical error: ${err}`);
+        logger.error("Terminating on critical error:", err);
 
         this._fail();
 

diff --git a/test/src/hermione.js b/test/src/hermione.js
@@ -728,12 +728,14 @@ describe("hermione", () => {
         });
 
         it("should log provided error", () => {
+            const err = new Error("test error");
+
             hermione.on(RunnerEvents.RUNNER_START, () => {
-                hermione.halt(new Error("test error"));
+                hermione.halt(err);
             });
 
             return hermione.run().finally(() => {
-                assert.calledOnceWith(logger.error, sinon.match(/Error: test error/));
+                assert.calledOnceWith(logger.error, "Terminating on critical error:", err);
             });
         });