Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retry logic because of new runners' API #19

Merged
merged 4 commits into from
Apr 1, 2016
Merged

Fix retry logic because of new runners' API #19

merged 4 commits into from
Apr 1, 2016

Conversation

eGavr
Copy link
Contributor

@eGavr eGavr commented Apr 1, 2016

Linked with supporting of sets.


/cc @sipayRT @j0tunn

@eGavr eGavr force-pushed the fix/retry branch 2 times, most recently from 8b06928 to b58501f Compare April 1, 2016 13:55
_getTestsToRetry: function() {
return _(this._matchers)
.groupBy('browser')
.mapValues(function(item) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

item->matchers

@j0tunn
Copy link
Contributor

j0tunn commented Apr 1, 2016

🆗

@@ -5,7 +5,7 @@
"main": "lib/hermione.js",
"scripts": {
"lint": "jshint . && jscs .",
"test-unit": "istanbul test _mocha -- --recursive test/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

почему эта опция не нужна?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

смотри ниже, он ее в опции mocha перенес

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не досмотрел :(

@eGavr eGavr merged commit 58d5c3e into master Apr 1, 2016
@eGavr eGavr deleted the fix/retry branch April 1, 2016 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants