fix: correctly disable test execution timeout in repl mode #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
commented
Jan 23, 2024
| @@ -51,7 +52,9 @@ function extendWithBrowserVersion({ treeBuilder, config }) { | |||
|
|
|||
| function extendWithTimeout({ treeBuilder, config }) { | |||
There was a problem hiding this comment.
Данная функция отвечает за установку testTimeout из конфига для каждого теста.
| @@ -17,6 +18,12 @@ export class ConfigController { | |||
| } | |||
|
|
|||
| testTimeout(timeout: number): this { | |||
There was a problem hiding this comment.
Отвечает за hermione.config.testTimeout(100500) перед тестом или сьютом
sipayRT
approved these changes
Jan 24, 2024
DudaGod
force-pushed
the
HERMIONE-1351.fix_disable_test_timeout_on_repl
branch
from
6980c44
to
bc91823
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing REPL mode, I added disabling the timeout in
config.system.mochaOpts.timeout, but I forgot about disablingtestTimeoutso in this PR I fixed it.