feat: add ability to use default export in .hermione.conf file #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuznetsovRoman
force-pushed
the
HERMIONE-1086.default_config_export
branch
from
5664e86
to
4dd05d8
Compare
DudaGod
approved these changes
Mar 7, 2024
| @@ -15,7 +15,10 @@ export class Config { | |||
|
|
|||
| static read(configPath: string): unknown { | |||
| try { | |||
| return require(path.resolve(process.cwd(), configPath)); | |||
| // eslint-disable-next-line @typescript-eslint/no-var-requires | |||
There was a problem hiding this comment.
а как оно раньше работало без этого коммента?
There was a problem hiding this comment.
На return require eslint не ругался. А тут, видимо, из-за того, что появилось название, начал.
KuznetsovRoman
force-pushed
the
HERMIONE-1086.default_config_export
branch
from
4dd05d8
to
b4e1d6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is done
export defaultin.hermione.conf.(j|t)sfile. At the moment.tsconfig has to beexport =