Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore TargetCloseError #874

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

KuznetsovRoman
Copy link
Member

No description provided.

@@ -3,7 +3,7 @@ export const shouldIgnoreUnhandledRejection = (err: Error | undefined): boolean
return false;
}

if (err.name === "ProtocolError") {
if (err.name === "ProtocolError" || err.name === "TargetCloseError") {
Copy link
Member Author

@KuznetsovRoman KuznetsovRoman Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавил это условие в существующий if, потому что ProtocolError и TargetCloseError настолько близки, что ProtocolError может быть с сообщением TargetCloseError:

TargetCloseError: Protocol error (Runtime.callFunctionOn): Target closed

@KuznetsovRoman KuznetsovRoman merged commit 67fd345 into master Mar 14, 2024
2 checks passed
@KuznetsovRoman KuznetsovRoman deleted the HERMIONE-1418.target_close_error branch March 14, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants