feat: add ability to show user log in component tests #905
Conversation
DudaGod
force-pushed
the
HERMIONE-1509.handle_console
branch
from
47d7401
to
9d6e735
Compare
| @@ -33,6 +34,8 @@ export class MochaWrapper { | |||
| } | |||
|
|
|||
| this._socket.emit(BrowserEventNames.initialize, getErrorsOnPageLoad(error)); | |||
|
|
|||
| wrapConsoleMethods(); | |||
There was a problem hiding this comment.
Do it before run any runnable. I do not call it earlier so that all sorts of browser system logs are not displayed
| socket.on(BrowserEventNames.callConsoleMethod, payload => { | ||
| const { runUuid } = socket.handshake.auth; | ||
|
|
||
| io.to(runUuid).except(socket.id).emit(BrowserEventNames.callConsoleMethod, payload); |
There was a problem hiding this comment.
I could call the console log right here (in master), but to my mind it's better to call it in the worker, that runs the test
| @@ -22,3 +22,5 @@ export const MAX_ARGS_LENGTH = 50; | |||
| // used from - https://github.com/jestjs/jest/blob/726ca20752e38c18e20aa21740cec7aba7891946/packages/pretty-format/src/plugins/AsymmetricMatcher.ts#L11-L14 | |||
| export const ASYMMETRIC_MATCHER = | |||
| typeof Symbol === "function" && Symbol.for ? Symbol.for("jest.asymmetricMatcher") : 0x13_57_a5; | |||
|
|
|||
| export const CONSOLE_METHODS = ["log", "info", "warn", "error", "debug"] as const; | |||
There was a problem hiding this comment.
What about trace? Would it work?
table also could be usefull.
There was a problem hiding this comment.
What about trace? Would it work?
It works, but stack trace is not quite helpful, because it called inside worker.
table also could be usefull.
Ok, I add it.
| console[method] = (...args: unknown[]): void => { | ||
| socket.emit(BrowserEventNames.callConsoleMethod, { method, args }); | ||
|
|
||
| origCommand(...args); |
There was a problem hiding this comment.
nit: I suggest to use return origCommand(...args) to preserve original API, just in case if sombody would overwrite console method too
There was a problem hiding this comment.
I have a synchronous event here. It means I can't return anything to browser. I don't see the point in such an implementation, since the real console methods is still running in the browser. Here I just show arguments in terminal.
DudaGod
force-pushed
the
HERMIONE-1509.handle_console
branch
from
9d6e735
to
b1f1b7c
Compare
What is done
Added the ability to show user log in nodejs environment when tests run in browser environment