docs: fix typos about the package version #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowusr
approved these changes
Apr 25, 2024
README.md
Outdated
| @@ -88,7 +88,7 @@ The documentation is divided into several sections: | |||
|
|
|||
| ## Rename from "Hermione" | |||
|
|
|||
| This project was formerly known as "Hermione", but eventually some copyright and trademark issues surfaced, leading to the decision to rebrand. After some discussion, we settled on "Testplane" as the official new title. We've tailored Testplane `v1` to be a drop-in replacement for Hermione `v8`. | |||
| This project was formerly known as "Hermione", but eventually some copyright and trademark issues surfaced, leading to the decision to rebrand. After some discussion, we settled on "Testplane" as the official new title. And since this is only a rebranding, we decided to implement continuous versioning instead of starting the versioning from the beginning. For this reason, Testplane `v8.x` is a drop-in replacement for Hermione `v8.x`. | |||
There was a problem hiding this comment.
I'd word it along the lines of Considering this change as merely a rebranding, we've proceeded with the existing version count instead of starting anew. Thus, ..., because "And since this is only..." feels a bit artificial, but feel free to keep your variant — not critical to me.
There was a problem hiding this comment.
I like the Considering... variant.
sipayRT
force-pushed
the
sp.fixDocsAboutVersions
branch
from
a197d4f
to
bf56c2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.