Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly screen element after moveTo #928

Merged
merged 1 commit into from
May 16, 2024
Merged

fix: correctly screen element after moveTo #928

merged 1 commit into from
May 16, 2024

Conversation

DudaGod
Copy link
Member

@DudaGod DudaGod commented May 15, 2024

fix - #779

shadowusr
shadowusr approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@shadowusr shadowusr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is round safe to use here in terms of flakiness? Would floor be better or not?

@DudaGod
Copy link
Member Author

DudaGod commented May 16, 2024

Is round safe to use here in terms of flakiness? Would floor be better or not?

It is safe because under the hood Math.floor is used for top and left coords and Math.ceil for right and bottom. Here - https://github.com/gemini-testing/testplane/blob/master/src/browser/client-scripts/rect.js#L80-L87

@DudaGod DudaGod merged commit b65169e into master May 16, 2024
2 checks passed
@DudaGod DudaGod deleted the TESTPLANE-20.fix_assert_view branch May 16, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadowusr shadowusr shadowusr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DudaGod @shadowusr