ARTEMIS-4020 Adding check on %s or %d on log.processor

gemmellr · Sep 28, 2022 · 4cfc4cb · 4cfc4cb
1 parent 9873fcc
commit 4cfc4cb
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/...in/java/org/apache/activemq/artemis/logs/annotation/processor/LogAnnotationProcessor.java b/...in/java/org/apache/activemq/artemis/logs/annotation/processor/LogAnnotationProcessor.java
@@ -473,6 +473,10 @@ private static void verifyMessagePlaceholders(final String message, final Execut
             throw new IllegalArgumentException("Invalid placeholder argument {" + tupple + "} on message \'" + message + "\' as part of " + holder + "\nreplace it by {}");
          }
       });
+
+      if (message.contains("%s") || message.contains("%d")) {
+         throw new IllegalArgumentException("Cannot use %s or %d in loggers. Please use {} on message \'" + message + "\'");
+      }
    }
 
    private static void verifyIdNotProcessedPreviously(final Integer id, final String message, final HashMap<Integer, String> processedMessages) {