Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for banning users. #163

Merged
merged 10 commits into from
Jan 8, 2022
Merged

Added support for banning users. #163

merged 10 commits into from
Jan 8, 2022

Conversation

w3bprinz
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Sep 25, 2021

Coverage Status

Coverage increased (+0.04%) to 97.956% when pulling 4e0af24 on w3bprinz:master into b173bfc on gempir:master.

@gempir
Copy link
Owner

gempir commented Sep 25, 2021

Please add a test for it, otherwise looks fine

@w3bprinz
Copy link
Contributor Author

Please add a test for it, otherwise looks fine

I'm not that familar with github, how can I add a test?

@gempir
Copy link
Owner

gempir commented Sep 27, 2021

This has nothing to do with github. I'd like to have a unit test for this functionality.

Other test for example https://github.com/gempir/go-twitch-irc/blob/master/client_test.go#L1007

Also the linter also still has issues with your code

@gempir
Copy link
Owner

gempir commented Sep 27, 2021

It might make sense to look at other tests like this as well because they actually assert the correct message which we want in this case. https://github.com/gempir/go-twitch-irc/blob/master/client_test.go#L1068

@gempir gempir merged commit 80f37cc into gempir:master Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants