Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callbacks for self JOIN/PART messages #182

Merged
merged 7 commits into from
Jun 12, 2022

Conversation

zneix
Copy link
Contributor

@zneix zneix commented Jun 5, 2022

Not sure if it's good to invoke the client callbacks within handle functions for JOIN/PART but it just seemed the simplest.
I'm not familiar with library's code much, thus I don't have a good idea about what potentially relevant tests I could add, but I'm open to experimenting and writing something. thanks pajlada for help figuring that out

One small side-note I have: name of the callback OnUserJoinMessage might be confusing, indicating it's carrying JOIN message for our user because of the User part in its name (ideally OnJoinMessage and OnSelfJoinMessage would make most sense to me). I know that's the name that was there from the beginning but I think it's only confusing if anything.
That's nothing that I can change though, just pointing that out...

Closes #178

@coveralls
Copy link

coveralls commented Jun 5, 2022

Coverage Status

Coverage increased (+0.02%) to 98.019% when pulling f773c9a on zneix:zneix/feat/handle-self-joins-parts into fde60d2 on gempir:master.

@gempir
Copy link
Owner

gempir commented Jun 12, 2022

Yeah I see how that could be a little misleading. But I think it's not worth breaking API over. Could you also update the readme to document the new callbacks?

@gempir gempir merged commit 8cf13b4 into gempir:master Jun 12, 2022
@zneix zneix deleted the zneix/feat/handle-self-joins-parts branch June 12, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not ignore incoming JOIN and PART messages for self user
3 participants