BG1/BG2: Subtitles appear even with the setting turned off

[Laulajatar]

Bug description

Even with the subtitle option checked off, the texts from party members saying their idle or selection dialogue gets dumped into the chat log.

Steps to reproduce

1. Disable subtitles
2. Stand around make a coffee
3. Check chat log

Expected behavior

When subtitles are turned off, they shouldn't appear in the log.

Screenshots

GemRB version (check as many as you know apply)

• master as of this issue
• 0.9.0
• 0.8.8
  (Just didn't test 0.9.0)

Video Driver (check as many as you know apply)

• SDL1.2
• SDL2 built with USE_OPENGL_BACKEND
• SDL2 without USE_OPENGL_BACKEND

[lynxlynxlynx]

Ok, so this is the "Subtitles" key (out of three possible), which we do check in DisplayStringCore. I guess it should effectively toggle DS_CONSOLE.