Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filesystem case sensitivity detection #1892

Open
bradallred opened this issue Aug 25, 2023 · 3 comments
Open

Add filesystem case sensitivity detection #1892

bradallred opened this issue Aug 25, 2023 · 3 comments
Labels
enhancement for features beyond the original's capabilities portability for things related to platform support

Comments

@bradallred
Copy link
Member

bradallred commented Aug 25, 2023

See commit 0869613

Lots of platforms use case insensitive filesystems, and many have both as an option. Therefore the most sane thing to do is implement runtime detection.

We should probably just remove it from the config, tho we should measure if this check adds measurable overhead to file resolution (I doubt it).

We do need to keep in mind that gemrb and the data are possibly on separate filesystems.

@bradallred bradallred added enhancement for features beyond the original's capabilities portability for things related to platform support labels Aug 25, 2023
@lynxlynxlynx
Copy link
Member

I disagree, we should just detect it. It's simple to test.

@bradallred
Copy link
Member Author

sure, I'll edit this to reflect that path.

@bradallred bradallred changed the title Add filesystem case sensitivity as a build time option Add filesystem case sensitivity detection Aug 25, 2023
@lynxlynxlynx
Copy link
Member

I think three path groups will be enough. One for our files, one for game files and one for saves (more likely to be stored on a different partition, especially on ees). Then we can do three simple checks on startup and have almost no overhead in later calls. It would require more VFS API adjustments though. Any better ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement for features beyond the original's capabilities portability for things related to platform support
Projects
None yet
Development

No branches or pull requests

2 participants