Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use char_traits for case insensitive comparison #1925

Open
bradallred opened this issue Oct 4, 2023 · 1 comment
Open

Use char_traits for case insensitive comparison #1925

bradallred opened this issue Oct 4, 2023 · 1 comment
Labels
bug system: core core engine stuff

Comments

@bradallred
Copy link
Member

see FIXMEs from ceb77ab. We need to be able to operate on a range of bytes, regardless of the presence of '\0' characters.

We need to create a std::char_traits like class for handling case insensitive comparison. Something like this.

The CstrHash, CstrLess, and CstrEq templates need to change their implementation to use traits instead of a string comparison function.

Likewise, StirngView and FixedSizeString both ought to have a template parameter for this and implement all comparisons through it.

@bradallred bradallred added the bug label Oct 4, 2023
@lynxlynxlynx lynxlynxlynx added the system: core core engine stuff label Oct 4, 2023
@lynxlynxlynx lynxlynxlynx added this to the 0.9.3 - TBN milestone Oct 4, 2023
@bradallred
Copy link
Member Author

IDSImporter can also leverage this to shed a bunch of stricmps.

@lynxlynxlynx lynxlynxlynx removed this from the 0.9.3 - TBN milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug system: core core engine stuff
Projects
None yet
Development

No branches or pull requests

2 participants