Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gamescript and dialog parsing tests #1930

Open
lynxlynxlynx opened this issue Oct 26, 2023 · 0 comments
Open

Add gamescript and dialog parsing tests #1930

lynxlynxlynx opened this issue Oct 26, 2023 · 0 comments
Labels
enhancement for features beyond the original's capabilities janitorial build system, cleanups, project mgmt system: scripting pertaining to scripts and dialogs

Comments

@lynxlynxlynx
Copy link
Member

We parse dialogs, since they contain uncompiled scripts and then we parse those as well. We cater to many exceptions in our current parser, since the data can be wonky and still worked in the original. So having a test suite for these will be very handy for maintaining a working state when resolving #1631 or similar.

GenerateTriggerCore, GenerateActionCore and GetStrings are the three key functions. The compiled bcs reading ones are in GameScript::CacheScript and callees.
@lynxlynxlynx lynxlynxlynx added enhancement for features beyond the original's capabilities system: scripting pertaining to scripts and dialogs janitorial build system, cleanups, project mgmt labels Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement for features beyond the original's capabilities janitorial build system, cleanups, project mgmt system: scripting pertaining to scripts and dialogs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lynxlynxlynx