Check new pc kit values #2055
Labels
bug
game: bg2
good first issue
tasks simple enough for someone completely new to the project
research needed
usually means testing in the original, to see how it behaved
In bg2 chargen we explicitly set the kit of specialist mages to the baseclass constant of 0x4000 or-ed with the kit index (row index in the kitlist table). NPCs like Edwin on the other hand have it set to the usability value directly (which are famously unique).
In iwd1 and bg1 we do the sane thing and just use usability (though there are only specialist mages kits present):
vs
This discrepancy is odd and should be investigated. It's also the reason we have to jump through hoops in
Actor::GetSpecialistSaveBonus
andgemrb/GUIScripts/GUICommon.py:354
. Since this is ancient code, I suspect we erroded the correct behaviour through time and either all kits should just use usability or specialist mages should be handled separately. Some remnants of that are in our magesch.2da handling, which also has a kit (usability) column.So:
The text was updated successfully, but these errors were encountered: